Skip to content

chore: use dpp 4.0.0-RC2-SNAPSHOT for testnet and 2.0.6-SNAPSHOT for …#1499

Merged
HashEngineering merged 13 commits into
masterfrom
chore/update-dpp-4
Jun 26, 2026
Merged

chore: use dpp 4.0.0-RC2-SNAPSHOT for testnet and 2.0.6-SNAPSHOT for …#1499
HashEngineering merged 13 commits into
masterfrom
chore/update-dpp-4

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

…mainnet

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

  • Chores
    • Improved how app variants use platform SDK versions, allowing different release channels to stay on the correct supported version.
    • Updated dependency handling so each build flavor is configured more consistently during packaging.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Gradle script now maps Dash Platform SDK versions by product flavor, removes the defaultConfig DPP_VERSION field, sets DPP_VERSION per flavor, and adds flavor-scoped Dash SDK dependencies for each flavor’s Java, Kotlin, and Android artifacts.

Changes

Flavor-scoped Dash Platform versioning

Layer / File(s) Summary
Version map and BuildConfig values
wallet/build.gradle
Defines dppVersions, removes the defaultConfig DPP_VERSION field, and sets DPP_VERSION from the current flavor in productFlavors.
Flavor-scoped Dash SDK dependencies
wallet/build.gradle
Updates the dependencies comments and adds flavor-specific dash-sdk-java, dash-sdk-kotlin, and dash-sdk-android declarations for each flavor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I’m a bunny in the build.gradle burrow 🐇
Hopping from flavor to flavor, version by version now
prod gets one hop, the others get another
Java, Kotlin, Android—snug as a cuddly mother
With a nibble and a twitch, the SDKs all align

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: per-flavor DPP version updates for testnet and mainnet.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-dpp-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from feat/ctx-redeem-url-support to master June 24, 2026 20:27

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@wallet/build.gradle`:
- Around line 18-23: The dppVersions entries in the wallet build are pointing at
SNAPSHOT coordinates that the build cannot reliably resolve in clean CI. Update
the version selection used by the wallet build so `org.dashj.platform:dash-sdk`
points to released artifacts instead of the missing SNAPSHOTs, or ensure the
`dppVersions` values are backed by artifacts published to Sonatype or preloaded
into `mavenLocal()` before resolution. Locate the change in the `dppVersions`
map in the build script and adjust the version constants used for `prod`,
`_testNet3`, `staging`, and `devnet` accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 41cfe591-ffec-480e-b0e3-e4f809df37f2

📥 Commits

Reviewing files that changed from the base of the PR and between e6b4aa7 and cebc5a4.

📒 Files selected for processing (1)
  • wallet/build.gradle

Comment thread wallet/build.gradle
@HashEngineering HashEngineering merged commit 660e345 into master Jun 26, 2026
3 checks passed
@HashEngineering HashEngineering deleted the chore/update-dpp-4 branch June 26, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants